Replace undefined std::Container<const T> with std::Container<T> #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See b/223663984: std::vector<const T> (and other container types:
deque/forward_list/list/multiset/queue/set/stack) are undefined and disallowed
by libstdc++. Future libc++ will report errors as well. Migrate to
std::Container<T> to bring code in-line with the C++ standard and the behavior
of other C++ standard libraries. Make similar changes to absl::flat_hash_set.
The clang-tidy check portability-std-allocator-const prevents backsliding.
LSC: http://go/replace-std-container-const-T
Tested:
TAP --sample ran all affected tests and none failed
http://test/OCL:672175733:BASE:672157811:1725764372183:9462f
PiperOrigin-RevId: 672175733
smolkaj
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace undefined std::Container with std::Container
std::vector (and other container types:
deque/forward_list/list/multiset/queue/set/stack) are undefined and disallowed
by libstdc++. Future libc++ will report errors as well. Migrate to
std::Container to bring code in-line with the C++ standard and the behavior
of other C++ standard libraries. Make similar changes to absl::flat_hash_set.