Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark test_docker_user_setting as requiring docker #303

Merged
merged 1 commit into from
Dec 6, 2024

Conversation

cottsay
Copy link
Member

@cottsay cottsay commented Dec 3, 2024

This test calls extend_cli_parser, which will fail if docker is not available.

Resolves:

test/test_core.py:246: in test_docker_user_setting
    extension_manager.extend_cli_parser(parser, default_args)
../../install_isolated/rocker/lib/python3.12/site-packages/rocker/core.py:131: in extend_cli_parser
    p.register_arguments(parser, default_args)
../../install_isolated/rocker/lib/python3.12/site-packages/rocker/extensions.py:209: in register_arguments
    client = get_docker_client()
../../install_isolated/rocker/lib/python3.12/site-packages/rocker/core.py:220: in get_docker_client
    raise DependencyMissing('Docker Client failed to connect to docker daemon.'
E   rocker.core.DependencyMissing: Docker Client failed to connect to docker daemon. Please verify that docker is installed and running. As well as that you have permission to access the docker daemon. This is usually by being a member of the docker group. The underlying error was:
E   """
E   Error while fetching server API version: ('Connection aborted.', FileNotFoundError(2, 'No such file or directory'))
E   """

This test calls extend_cli_parser, which will fail if docker is not
available.
@cottsay cottsay added the bug Something isn't working label Dec 3, 2024
@cottsay cottsay self-assigned this Dec 3, 2024
@cottsay cottsay requested a review from tfoote as a code owner December 3, 2024 18:36
Copy link
Collaborator

@tfoote tfoote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's unfortunate that anywhere that has the Network plugin it will fail if docker isn't present due to https://github.com/osrf/rocker/blame/b150019a1f66cf39e9e860c95eadacdf6acd8f97/src/rocker/extensions.py#L209

When parsing args, but really w/o docker this isn't super useful. So I'm not going to try to find a way around this at the moment.

@tfoote tfoote merged commit 89af699 into main Dec 6, 2024
8 checks passed
@tfoote tfoote deleted the cottsay/more-test-markings branch December 6, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants