Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close message on click #2742

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from
Draft

Conversation

ZakarFin
Copy link
Member

@ZakarFin ZakarFin commented Nov 25, 2024

Allows user to click a message to close it. Example in this case the notification "Antamallasi hakusanalla ei löytynyt yhtään kohdetta":

image

@ZakarFin
Copy link
Member Author

Related to OS-2598 (internal ticketing)

@ZakarFin
Copy link
Member Author

ZakarFin commented Nov 25, 2024

Draft for now since I'm not sure if we want to add this for all notifications (actually messages is the AntD component). But it looks like onClick can't be passed by the caller: https://github.com/oskariorg/oskari-frontend/blob/2.13.2/src/react/util/extras/Messaging.js#L43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant