Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update documentation #52
base: develop
Are you sure you want to change the base?
Update documentation #52
Changes from 5 commits
6093911
4d44ac8
9432d1b
662678d
b92f641
cb2993d
11da878
1cf0f73
914cfc0
eb07a7b
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We now use folder and directory as terms. Maybe we should pick one and stick to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wikipedia is not a reliable source per se, but I've understood the difference between the terms as mentioned there:
"If one is referring to a container of documents, the term folder is more appropriate. The term directory refers to the way a structured list of document files and folders is stored on the computer. "
Thus I'd say that in this very context directory is a appropriate term, whereas in other contexts folder is more suitable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"The bundle definition (or package) should be located in
bundle.js
file under the/packages
folder". This is not always true anymore and this might change in a very near future. However, for now I think this might be accurate enough.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, any CSS and most of Javascript can be imported now on for example the instance.js. The
bundle.js
file is currently mostly used for picking what the files that need to be imported when a bundle with certain id is being used in the app AND the way to include and split localization files when the application is built.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated this part for now combining these two different perspectives. When the very near future arrives and this needs revising, will do further fixes.