internal/v1: export snapshot date #1406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avitova
force-pushed
the
export-snapshot-date
branch
from
164327e
to
54814c1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
|
ezr-ondrej
approved these changes
Nov 18, 2024
There was a problem hiding this comment.
Thanks @avitova ! I think it's great 👍 Would love to hear @croissanne opinion before merge tho :)
lzap
approved these changes
Nov 21, 2024
| type: string | ||
| description: | | ||
| Importing the snapshot date will not yet be supported. It is exported for informative reasons. | ||
| The format is YYYY-MM-DD. |
There was a problem hiding this comment.
Isntt there a date type in OpenAPI JSON Schema?
There was a problem hiding this comment.
Might be, but I would probably leave this in the same format that we have in the image requests snapshot_date field for consistency.
avitova
force-pushed
the
export-snapshot-date
branch
from
54814c1
to
e374cd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started a conversation about importing and exporting snapshot dates. Our team thought that it would be convenient to export the snapshot date. We might have a follow-up discussion about importing it as well, but there are some issues that we need to handle.
In the wizard, we currently do not limit how much in the history the user can pick the snapshot date, so maybe we can just import it as is on the front end. @croissanne ? But then, users also import custom repositories, and they would most likely not have that snapshot from the history.
The discussion's outcome was to keep the feature without importing the snapshot date, but we will keep that option for the future. What do we think? We can mention somewhere that this value is not being imported.