Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gRPC gateway #1238

Open
wants to merge 30 commits into
base: master
Choose a base branch
from
Open

feat: gRPC gateway #1238

wants to merge 30 commits into from

Conversation

hperl
Copy link
Collaborator

@hperl hperl commented Feb 13, 2023

Related issue(s)

Checklist

  • I have read the contributing guidelines.
  • I have referenced an issue containing the design document if my change
    introduces a new feature.
  • I am following the
    contributing code guidelines.
  • I have read the security policy.
  • I confirm that this pull request does not address a security
    vulnerability. If this pull request addresses a security vulnerability, I
    confirm that I got the approval (please contact
    [email protected]) from the maintainers to push
    the changes.
  • I have added tests that prove my fix is effective or that my feature
    works.
  • I have added or changed the documentation.

Further Comments

@hperl hperl force-pushed the hperl/exp/grpc-gateway branch 3 times, most recently from 33496b2 to 4c0edb2 Compare February 21, 2023 15:31
@hperl hperl marked this pull request as ready for review February 22, 2023 15:05
@hperl hperl requested a review from zepatrik as a code owner February 22, 2023 15:05
zepatrik
zepatrik reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@zepatrik zepatrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, the handler code looks very appealing 👍
I have a bunch of questions though.

cmd/expand/root_test.go Outdated Show resolved Hide resolved
contrib/docs-code-samples/expand-api-display-access/01-expand-beach/expected_output.json Show resolved Hide resolved
internal/e2e/full_suit_test.go Show resolved Hide resolved
internal/e2e/sdk_client_test.go Show resolved Hide resolved
internal/driver/daemon.go Outdated Show resolved Hide resolved
proto/ory/keto/relation_tuples/v1alpha2/check_service.proto Show resolved Hide resolved
proto/ory/keto/relation_tuples/v1alpha2/check_service.proto Show resolved Hide resolved
proto/ory/keto/relation_tuples/v1alpha2/check_service.proto Show resolved Hide resolved
@hperl hperl requested a review from zepatrik February 28, 2023 12:56
@hperl
Copy link
Collaborator Author

hperl commented Mar 12, 2023

@zepatrik this is ready for another round of reviews while I testdrive this internally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zepatrik zepatrik zepatrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hperl @zepatrik