Fix that std was Still Required Through lazy_static
#15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make lazy_static optional, since it isn't even needed without alloc. This should be backwards compatible, since lazy_static is not in the public API. Still, since lazy_static, by default needs std this commit adds also some rational, about how to use this crate with alloc but ensuring that lazy_static will not use std.
orhanbalci
approved these changes
Apr 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make
lazy_staticoptional, since it isn't even needed withoutalloc.This should be backwards compatible, since
lazy_staticis not in the public API.Still, since
lazy_static, by default needsstdthis PR also adds some rational,about how to use this crate with
allocbut ensuring thatlazy_staticwill not usestd.Also see: rust-lang-nursery/lazy-static.rs#150