Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update parent POM #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Update parent POM #2

wants to merge 3 commits into from

Conversation

cstamas
Copy link

@cstamas cstamas commented Apr 14, 2023

Changes:

  • remove prerequisite (is for maven-plugin packaging only, added enforcer instead)
  • update plugins
  • add globally enforcer (to enforce modern Maven)
  • clean up
  • drop Sonatype brain-dead plugin (will require manual close, that's all)
  • this above to be able to utilize latest 3.1.1 deployAtEnd etc

Changes:
* update plugins
* add globally enforcer (to enforce modern Maven)
* clean up
* drop Sonatype brain-dead plugin (will require manual close, that's all)
* this above to be able to utilize latest 3.1.1 deployAtEnd etc
@grgrzybek
Copy link
Member

Thanks @cstamas however let me think a bit about this ;)
I've kind of inherited the release process for OPS4J (@jbonofre is sometimes releasing OPS4J artifacts too) and it's a bit fragile - I'm not sure how it'll impact release process via https://oss.sonatype.org/#stagingRepositories..

But that's really something to consider - let me check next week.

@grgrzybek grgrzybek self-requested a review April 14, 2023 08:04
@cstamas
Copy link
Author

cstamas commented Apr 14, 2023

As I see from current master, all that sonatype plugin was doing is "close" staging repo, nothing more. With removal of this plugin this will be the "only thing" lost (so will require manual step for user to browse to ossrh, login and close repo). OTOH, what you gain is use of modern resolver transport, proper deployAtAnd support and many more (as staging plugin replaces maven plugins).

@grgrzybek
Copy link
Member

got it - and I've debugged sonatype-maven-plugin, which does some tricky replacement of maven-deploy-plugin executions from the lifecycle - it'd be good to switch to canonical Maven usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants