Answer question of directionality #1105
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue #1098 resolved to make the switch adapt to flow direction of scripts and render the "on" state on the left side for `rtl` and on the right side for `ltr`.
gfellerph
requested review from
gregwhitworth,
mfreed7 and
dbaron
as code owners
gregwhitworth
approved these changes
Nov 24, 2024
There was a problem hiding this comment.
I left a comment or two and I'll assume you'll make those changes prior to landing the PR. Additionally, for your open questions you should open issues around them and link to them. That doesn't need to be a part of this PR unless you'd like it to be. Thank you for your work on this.
| @@ -525,9 +525,16 @@ The switch element can be associated with the existing `role="switch"`. | |||
| ### Globalization | |||
|
|
|||
| <div class="question"> | |||
| Is thumb in the "on" position on the left in a `rtl` directional environment? | |||
| How should the switch behave in writing modes other than `horizontal-tb`? | |||
There was a problem hiding this comment.
Since you have an answer to the question, please remove the question
There was a problem hiding this comment.
That said, we didn't resolve on the vertical scenario so there should probably be a new question elsewhere (maybe replace this text) and open a new issue and link to that one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1098 which resolved to make the switch adapt to flow direction of scripts and render the "on" state on the left side for
rtland on the right side forltr.