Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite content minimum width #4103

Merged
merged 1 commit into from
Oct 18, 2024
Merged

fix: rewrite content minimum width #4103

merged 1 commit into from
Oct 18, 2024

Conversation

Ricbet
Copy link
Member

@Ricbet Ricbet commented Oct 17, 2024

Types

  • 🐛 Bug Fixes

Background or solution

before:
image

after:
image

Changelog

限制 rewrite 面板的最小宽度

Summary by CodeRabbit

  • 新功能
    • 改进了虚拟编辑器的布局,确保文本变化的视觉表现更加准确。
    • 更新了装饰的渲染逻辑,使其更好地与新的布局计算集成。

@Ricbet Ricbet self-assigned this Oct 17, 2024
@opensumi opensumi bot added the 🐞 bug Something isn't working label Oct 17, 2024
Copy link
Contributor

coderabbitai bot commented Oct 17, 2024

Walkthrough

此次更改主要集中在rewrite-widget.tsx文件,增强了TextBoxProvider组件和RewriteWidget类的功能。新增变量contentLeft用于从虚拟编辑器中获取布局信息,并在changeDecorations方法中调整宽度计算,以确保编辑器的宽度考虑左侧内容的边距,从而改善虚拟编辑器的布局。此外,setEditorSize函数和layout方法也进行了修改,以提升小部件在文本变更时的响应能力和可视化效果。

Changes

文件路径 更改摘要
packages/ai-native/src/browser/widget/rewrite/rewrite-widget.tsx 增加contentLeft变量以获取布局信息,更新changeDecorationssetEditorSize方法以改进宽度计算和小部件布局。

Possibly related PRs

  • fix: improve inline diff widget render #4100: 此PR涉及对live-preview.decoration.tsx文件的修改,相关性在于它处理小部件的渲染逻辑,与本PR中对RewriteWidget类的增强相似。两个PR都专注于改善编辑器中小部件状态的视觉表现和处理。

Suggested labels

🐞 bug

Suggested reviewers

  • erha19
  • bytemain

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between 0cace90 and 196c8b3.

📒 Files selected for processing (1)
  • packages/ai-native/src/browser/widget/rewrite/rewrite-widget.tsx (2 hunks)
🧰 Additional context used
🔇 Additional comments (2)
packages/ai-native/src/browser/widget/rewrite/rewrite-widget.tsx (2)

132-132: 代码更新正确地获取了 contentLeft

此行代码正确地从 virtualEditor 的选项中获取了 contentLeft,用于后续的布局计算,符合预期逻辑。


153-153: 宽度计算正确地包含了左右边距

在计算编辑器的宽度时,使用了 maxColumnWidth * spaceWidth + contentLeft * 2,正确地考虑了左右两侧的边距,确保了虚拟编辑器布局的准确性。


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (0cace90) to head (196c8b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4103   +/-   ##
=======================================
  Coverage   54.33%   54.33%           
=======================================
  Files        1594     1594           
  Lines       97415    97415           
  Branches    19932    19940    +8     
=======================================
  Hits        52931    52931           
  Misses      36948    36948           
  Partials     7536     7536           
Flag Coverage Δ
jsdom 49.88% <ø> (ø)
node 15.62% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hacke2 hacke2 merged commit f112878 into main Oct 18, 2024
13 checks passed
@hacke2 hacke2 deleted the fix/improve-rewrite-width branch October 18, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants