drop hardcoded openvswitch user/group definitions #1317
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
If this isn't desirable I think we can simply add back in the hardcoding and leave the workaround script in place and it will still solve the problem. |
|
/retest
…On Sat, Jun 17, 2023, at 20:16, openshift-ci[bot] wrote:
@dustymabe <https://github.com/dustymabe>: The following test *failed*, say `/retest` to rerun all failed tests or `/retest-required` to rerun all mandatory failed tests:
Test name
Commit
Details
Required
Rerun command
ci/prow/scos-9-build-test-qemu
9baecec
link <https://prow.ci.openshift.org/view/gs/origin-ci-test/pr-logs/pull/openshift_os/1317/pull-ci-openshift-os-master-scos-9-build-test-qemu/1670184784791343104>
true
`/test scos-9-build-test-qemu`
Full PR test history <https://prow.ci.openshift.org/pr-history?org=openshift&repo=os&pr=1317>. Your PR dashboard <https://prow.ci.openshift.org/pr?query=is:pr+state:open+author:dustymabe>.
Instructions for interacting with me using PR comments are available here <https://git.k8s.io/community/contributors/guide/pull-requests.md>. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra <https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:> repository. I understand the commands that are listed here <https://go.k8s.io/bot-commands>.
—
Reply to this email directly, view it on GitHub <#1317 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABCR63VT55FJTAM2YTIMXC3XLZCHRANCNFSM6AAAAAAZKOWUDY>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
The RPM is now using systemd-sysusers fragments [1] so we can drop the hardcoded definitions. One problem here, though, is that the hugetlbfs group never gets added to the openswitch user [2] so let's add a workaround for that for now. One side effect of this is that it does change the previously defined UID/GIDs from 800/801 to different values (dynamically generated at build time). I assume this is OK because of some of the discussion in [1]. [1] openshift#1274 (comment) [2] openshift#1274 (comment)
dustymabe
force-pushed
the
dusty-fix-openvswitch-groups
branch
from
9baecec to
39660a3
Compare
This comment was marked as outdated.
This comment was marked as outdated.
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lifecycle frozen |
|
@travier: Reopened this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@travier: The In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
removed
the
lifecycle/rotten
|
@dustymabe: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Issues go stale after 90d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle stale |
openshift-ci
bot
added
the
lifecycle/stale
|
Stale issues rot after 30d of inactivity. Mark the issue as fresh by commenting If this issue is safe to close now please do so with /lifecycle rotten |
openshift-ci
bot
added
lifecycle/rotten
|
Rotten issues close after 30d of inactivity. Reopen the issue by commenting /close |
|
@openshift-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
The RPM is now using systemd-sysusers fragments [1] so we can drop the hardcoded definitions. One problem here, though, is that the hugetlbfs group never gets added to the openswitch user [2] so let's add a workaround for that for now.
One side effect of this is that it does change the previously defined UID/GIDs from 800/801 to different values (dynamically generated at build time). I assume this is OK because of some of the discussion in [1].
[1] #1274 (comment)
[2] #1274 (comment)