Fix SO index #3056
Fix SO index #3056
Conversation
Our Dockerfile for Index image is now pulling `registry.ci.openshift.org/knative/release-1.35.0:serverless-bundle` on line 14 as the bundle now exists. It doesn't pull the the previously built `image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-bundle:latest` and the release-1.35.0 bundle references images at `registry.redhat.io` which are not pullable yet. Signed-off-by: Pierangelo Di Pilato <[email protected]>
|
/cherry-pick release-1.35 |
|
@pierDipi: once the present PR merges, I will cherry-pick it on top of In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: creydr, mgencur, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
We need this after each cut? Do we need to document it in the template as in here: #2989? |
| @@ -10,10 +10,6 @@ COPY olm-catalog/serverless-operator-index/configs /configs | |||
| RUN /bin/opm init serverless-operator --default-channel=stable --output yaml >> /configs/index.yaml | |||
| RUN /bin/opm render --skip-tls-verify -o yaml \ | |||
| registry.ci.openshift.org/knative/release-1.33.0:serverless-bundle \ | |||
| registry.ci.openshift.org/knative/release-1.34.0:serverless-bundle \ | |||
| registry.ci.openshift.org/knative/release-1.35.0:serverless-bundle >> /configs/index.yaml || \ | |||
There was a problem hiding this comment.
Not needed. See my comment below.
No. That's a one-time change. We had that before because we wanted to be able to install Serverless operator from "main" and from release branch without rebuilding the Bundle (i.e. faster setup - for periodic jobs or local runs). But now we need to rebuild the Bundle every time because we replace registry.redhat.io references with quay.io. So, the bundle will be rebuilt correctly for each branch. |
Is there going to be a 1.36 entry ( |
No. |
no, I don't think so |
Can we merge anyway? |
2 similar comments
|
@pierDipi: new pull request created: #3061 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Our Dockerfile for Index image is now pulling
registry.ci.openshift.org/knative/release-1.35.0:serverless-bundleon line 14 as the bundle now exists.It doesn't pull the the previously built
image-registry.openshift-image-registry.svc:5000/openshift-marketplace/serverless-bundle:latestand the release-1.35.0 bundle references images atregistry.redhat.iowhich are not pullable yet.Originally reported here: #3054 (comment)