Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: Refactor filters in the S-IED creation #1603

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

bugfix: Refactor filters in the S-IED creation #1603

wants to merge 7 commits into from

Conversation

illia-solovei-s1
Copy link

No description provided.

@illia-solovei-s1
Copy link
Author

Notes for takeover

Done

  • The desc attribute is now a requirement for every S-IED.
  • Added a warning banner that appears if S-IEDs without description are found.
  • A click on the banner opens a special wizard to edit the description of the first no-desc S-IED in the list. After editing the user can click on the banner again to edit the next problematic element. If there are no such items left - the banner disappears.

Problems and next steps

  • Include desc attribute in the filtering logic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
Quality Improvements
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@illia-solovei-s1