Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX]: Fix Help page linking error #1594

Merged
merged 6 commits into from
Nov 22, 2024

Conversation

salvar3nga
Copy link
Contributor

@salvar3nga salvar3nga commented Nov 15, 2024

Description

See issue #532

Screenshots

BEFORE

previous_help_page

AFTER

current_help_page

@salvar3nga salvar3nga changed the title [BUG]: Fix error Help page linking error [BUGFIX]: Fix error Help page linking error Nov 15, 2024
salvar3nga and others added 2 commits November 15, 2024 15:44
- Help.ts:  move regex into explainatory variables
- finder-list.ts: remove unnecessary Fn
@salvar3nga salvar3nga changed the title [BUGFIX]: Fix error Help page linking error [BUGFIX]: Fix Help page linking error Nov 18, 2024
Sergio Alvarenga added 3 commits November 18, 2024 09:57
Test was failing for previously removing the "getDisplayString" method
@salvar3nga salvar3nga marked this pull request as ready for review November 18, 2024 14:28
Copy link

@illia-solovei-s1 illia-solovei-s1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@trusz trusz merged commit 29e5fed into openscd:main Nov 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants