Skip to content

Commit

Permalink
chore: fixing reactivity after refactoring plugins rendering... (#1524)
Browse files Browse the repository at this point in the history
test: fixing snapshot tests for passing down plugins as props

Signed-off-by: Juan Munoz <[email protected]>
  • Loading branch information
juancho0202 authored May 13, 2024
1 parent d634c61 commit 61e0d14
Show file tree
Hide file tree
Showing 4 changed files with 2,187 additions and 45 deletions.
44 changes: 28 additions & 16 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion packages/open-scd/src/open-scd.ts
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,7 @@ export class OpenSCD extends LitElement {

private storePlugins(plugins: Array<Plugin | InstalledOfficialPlugin>) {
localStorage.setItem('plugins', JSON.stringify(plugins.map(withoutContent)));
this.requestUpdate();
this._sortedStoredPlugins = this.sortedStoredPlugins;
}
private resetPlugins(): void {
Expand Down Expand Up @@ -413,7 +414,6 @@ export class OpenSCD extends LitElement {
return { ...plugin, installed: indices.has(index) };
});
this.storePlugins(newPlugins);
this.requestUpdate();
}

private updatePlugins() {
Expand Down
Loading

0 comments on commit 61e0d14

Please sign in to comment.