don't break the clickable links in emails #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
People often try to reclick links they've used before they expire (which is usually next day anyway), especially now we have per-year submissions and people backfill missing years. It matters less for email addresses which can easily recreate links (nhs.net etc), but matters a lot for those who (now) have to re-request a custom link (@gmail.com etc). Not sure this is the right/only place, so needs review from someone who wrote this code. Not urgent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People often try to reclick links they've used before they expire (which is usually next day anyway), especially now we have per-year submissions and people backfill missing years. It matters less for email addresses which can easily recreate links (nhs.net etc), but matters a lot for those who (now) have to re-request a custom link (@gmail.com etc). Not sure this is the right/only place, so needs review from someone who wrote this code. Not urgent