Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI test suite #26

Merged
merged 11 commits into from
Apr 4, 2023
Merged

CI test suite #26

merged 11 commits into from
Apr 4, 2023

Conversation

why-not-try-calmer
Copy link
Contributor

The official test suite is not CI-ready; it uses a web client requiring manual input:

Capture d’écran du 2023-04-03 10-58-50

The wrapper script proposed here should make our lives a bit easier.

@why-not-try-calmer why-not-try-calmer force-pushed the ogc-test-suite branch 2 times, most recently from bfce844 to 6afc9f3 Compare April 3, 2023 09:44
@why-not-try-calmer why-not-try-calmer marked this pull request as draft April 3, 2023 10:03
@why-not-try-calmer
Copy link
Contributor Author

This actually needs more debugging. WIP.

@why-not-try-calmer why-not-try-calmer force-pushed the ogc-test-suite branch 9 times, most recently from 61eb6e9 to 052f0dc Compare April 4, 2023 07:59
docker-compose.tests.yml Outdated Show resolved Hide resolved
docker-compose.tests.yml Outdated Show resolved Hide resolved
conformance-tests/ogcf.py Outdated Show resolved Hide resolved
@why-not-try-calmer why-not-try-calmer force-pushed the ogc-test-suite branch 2 times, most recently from 7c3477d to fbc1db1 Compare April 4, 2023 10:34
@why-not-try-calmer why-not-try-calmer force-pushed the ogc-test-suite branch 2 times, most recently from 61bf78c to 76660b5 Compare April 4, 2023 10:48
@olivierdalang
Copy link
Contributor

Changed the approach to use directly the CLI. Unfortunately their provided Docker image doesn't contain the CLI executable. Fortunately someone did the work already: opengeospatial/ets-ogcapi-features10#197

I also added the test at the end of the already existing quickstart test, as anyway the test always succeed for now because it exits with 0 even if there are issues. We can improve that once the test result start to be meaningful (e.g. once we're more or less conform).

The CI uploads the result to the artifacts (current run: https://github.com/opengisch/signalo-oapif/suites/12019989528/artifacts/631510246)

olivierdalang
olivierdalang previously approved these changes Apr 4, 2023
@olivierdalang olivierdalang dismissed their stale review April 4, 2023 13:43

changed approach

@olivierdalang olivierdalang marked this pull request as ready for review April 4, 2023 13:45
@olivierdalang olivierdalang self-requested a review April 4, 2023 13:45
@why-not-try-calmer why-not-try-calmer merged commit 97d8bee into main Apr 4, 2023
@why-not-try-calmer why-not-try-calmer deleted the ogc-test-suite branch April 18, 2023 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants