Refactor image #82
Open
Refactor image #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EBCEEB
commented
Dec 5, 2017
EBCEEB
commented
- introduce build args to override settings using docker CLI
- use the single ENV to reduce number of layers
- use the single RUN to reduce number of layers
- switch to use ADD instead of running curl
- place plugins directly to plugin directory
- some other cosmetic fixes
- introduce build args to override settings using docker CLI - use the single ENV to reduce number of layers - use the single RUN to reduce number of layers - switch to use ADD instead of running curl - place plugins directly to plugin directory - some other cosmetic fixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.