Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt database connection creator #123

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from
Open

Adapt database connection creator #123

wants to merge 4 commits into from

Conversation

gplssm
Copy link
Contributor

@gplssm gplssm commented Jun 21, 2017

This branch provides OEDB connection establishment via ego.io own config file. If this config file does not exist, it should be interactively be created (the computer will ask you ;-) ).

This new functionality relies of methods available in "features/own-config-file" of ego.io. Please use this branch to test this PR. Once, the PR is merged we need a new ego.io Release. I suggest to make a 0.2.1 release

For the reviewers, please check if the data_processing script still runs and everything works like normal/expected.

@gplssm gplssm added this to the Release ego v0.3 milestone Jun 21, 2017
Copy link
Member

@lukasol lukasol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I never run the dp I cannot really test and thus review this PR. I think @ulfmueller and @Ludee are the ones that could do so.

@gplssm
Copy link
Contributor Author

gplssm commented Jun 21, 2017

@lukasol I think review by @ulfmueller and @Ludee is sufficient. Thx.

@Ludee
Copy link
Member

Ludee commented Jun 22, 2017

Start testing now:
ego.io branch = features/own-config-file
data_processing branch = fix/#18

@Ludee
Copy link
Member

Ludee commented Jun 22, 2017

creation of .egoio/config.ini works.
The use of the file didn't work for me. I get asked for connection details again.

@Ludee
Copy link
Member

Ludee commented Jun 22, 2017

Problem was that oemof.db has to be installed in the newest version (v0.0.5)

Copy link
Member

@Ludee Ludee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is complicated (three repos) with a lot of potential errors. But it works as desired.
A future job is to combine everything in oemof.db

@Ludee
Copy link
Member

Ludee commented Jul 6, 2017

Is this still part of MS Release v0.3 or do we move it to v0.3.1? @gplssm

@gplssm gplssm modified the milestones: Release ego v0.3.1, Release ego v0.3 Jul 10, 2017
@gplssm
Copy link
Contributor Author

gplssm commented Jul 10, 2017

We move it because it requires work to be done in ego.powerflow

@nesnoj
Copy link
Member

nesnoj commented Aug 30, 2017

The db access stuff is finished in openego/ego.io#34 and is ready for use. This PR might needs to be adapted..

@IlkaCu
Copy link
Member

IlkaCu commented Apr 18, 2018

This PR is pretty old and still open. @gplssm: Is it still relevant?

@gplssm
Copy link
Contributor Author

gplssm commented Apr 24, 2018

To be honest, I suggest to re-start from scratch! Changes included in this PR are pretty small and not to innovative. Furthermore, these are quite outdated...
If we still have the plan to align DB connection provider with other packages in the openego context, I suggest to use ego.io's connection provide as it's used in Ding0/eDisGo.

@ulfmueller
Copy link
Member

I agree with @gplssm since in the meantime we created our own db connector in ego.io now without dependencies to oemof, we can use it like in the other apps (eTraGo, eDisGo and so on). Close this PR and create an issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants