Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include credentials when cookie across subdomains #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ghassanmas
Copy link
Member

This URL of fetching guest_token is always LMS_ROOT_URL, however
in case multisite is being used the guest could be in a different
url. This change ensure that cookie is being sent if the other
site is a subdomain or shares parent domain with LMS_URL_ROOT

This might be realted to openedx/tutor-contrib-aspects/issues/925

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 13, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @ghassanmas!

What's next?

Please work through the following steps to get your changes ready for engineering review:

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

🔘 Let us know that your PR is ready for review:

Who will review my changes?

This repository is currently maintained by @bmtcril. Tag them in a comment and let them know that your changes are ready for review.

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

Copy link
Contributor

@Ian2012 Ian2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Can you bump the version?

 This URL of fetching guest_token is always LMS_ROOT_URL, however
 in case multisite is being used the guest could be in a different
 url. This change ensure that cookie is being sent if the other
 site is a subdomain or shares parent domain with LMS_URL_ROOT

 This might be realted to openedx/tutor-contrib-aspects/issues/925
@ghassanmas
Copy link
Member Author

@Ian2012 I just did, thanks for quick review :)

@Ian2012
Copy link
Contributor

Ian2012 commented Nov 14, 2024

I was testing it locally however I'm getting cors error. Can you provide testing instructions?

I did:

  • Create site configuration for demo.local.edly.io:8000.
  • Open the instructor dashboard from that domain.
  • Load Aspects:

image

Copy link

@arbrandes arbrandes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The principle is ok, but I haven't been able to test that it actually works. If somebody can confirm this does the trick, I would support merging it.

@Ian2012
Copy link
Contributor

Ian2012 commented Nov 14, 2024

@ghassanmas Maybe you should include the site configuration changes you were proposing in this comment openedx/tutor-contrib-aspects#925 (comment). However, if you are going to do that, then you can drop the current changes as those will not be needed anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Ready for Review
Development

Successfully merging this pull request may close these issues.

4 participants