-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: include credentials when cookie across subdomains #106
base: main
Are you sure you want to change the base?
Conversation
Thanks for the pull request, @ghassanmas! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently maintained by Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution! Can you bump the version?
This URL of fetching guest_token is always LMS_ROOT_URL, however in case multisite is being used the guest could be in a different url. This change ensure that cookie is being sent if the other site is a subdomain or shares parent domain with LMS_URL_ROOT This might be realted to openedx/tutor-contrib-aspects/issues/925
8e7de53
to
7844cd0
Compare
@Ian2012 I just did, thanks for quick review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The principle is ok, but I haven't been able to test that it actually works. If somebody can confirm this does the trick, I would support merging it.
@ghassanmas Maybe you should include the site configuration changes you were proposing in this comment openedx/tutor-contrib-aspects#925 (comment). However, if you are going to do that, then you can drop the current changes as those will not be needed anymore. |
This URL of fetching guest_token is always LMS_ROOT_URL, however
in case multisite is being used the guest could be in a different
url. This change ensure that cookie is being sent if the other
site is a subdomain or shares parent domain with LMS_URL_ROOT
This might be realted to openedx/tutor-contrib-aspects/issues/925