Skip to content

Commit

Permalink
Merge branch 'kiram15/ENT-9670' of ssh://github.com/openedx/edx-platf…
Browse files Browse the repository at this point in the history
…orm into kiram15/ENT-9670
  • Loading branch information
kiram15 committed Nov 27, 2024
2 parents a751266 + 085a5c3 commit 8ef3c11
Show file tree
Hide file tree
Showing 10 changed files with 20 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ def send_new_comment_notification(self):
"author_name": str(author_name),
"author_pronoun": str(author_pronoun),
"email_content": clean_thread_html_body(self.comment.body),
"group_by_id": self.parent_response.id
}
self._send_notification([self.thread.user_id], "new_comment", extra_context=context)

Expand Down
2 changes: 0 additions & 2 deletions lms/djangoapps/discussion/rest_api/tests/test_tasks.py
Original file line number Diff line number Diff line change
Expand Up @@ -362,7 +362,6 @@ def test_send_notification_to_parent_threads(self):
'replier_name': self.user_3.username,
'post_title': self.thread.title,
'email_content': self.comment.body,
'group_by_id': self.thread_2.id,
'author_name': 'dummy\'s',
'author_pronoun': 'dummy\'s',
'course_name': self.course.display_name,
Expand Down Expand Up @@ -439,7 +438,6 @@ def test_comment_creators_own_response(self):
expected_context = {
'replier_name': self.user_3.username,
'post_title': self.thread.title,
'group_by_id': self.thread_2.id,
'author_name': 'dummy\'s',
'author_pronoun': 'your',
'course_name': self.course.display_name,
Expand Down
1 change: 0 additions & 1 deletion openedx/features/enterprise_support/tests/test_api.py
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,6 @@

LOGGER_NAME = "edx.enterprise_helpers"


class MockEnrollment(mock.MagicMock):
"""
Mock object for an enrollment which has a consistent string representation
Expand Down
18 changes: 14 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@
"karma-webpack": "^5.0.1",
"plato": "1.7.0",
"react-test-renderer": "16.14.0",
"selenium-webdriver": "4.26.0",
"selenium-webdriver": "4.27.0",
"sinon": "19.0.2",
"squirejs": "0.1.0",
"string-replace-loader": "^3.1.0",
Expand Down
2 changes: 1 addition & 1 deletion requirements/constraints.txt
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ optimizely-sdk<5.0
# Date: 2023-09-18
# pinning this version to avoid updates while the library is being developed
# Issue for unpinning: https://github.com/openedx/edx-platform/issues/35269
openedx-learning==0.18.0
openedx-learning==0.18.1

# Date: 2023-11-29
# Open AI version 1.0.0 dropped support for openai.ChatCompletion which is currently in use in enterprise.
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/base.txt
Original file line number Diff line number Diff line change
Expand Up @@ -827,7 +827,7 @@ openedx-filters==1.11.0
# -r requirements/edx/kernel.in
# lti-consumer-xblock
# ora2
openedx-learning==0.18.0
openedx-learning==0.18.1
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/kernel.in
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/development.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1386,7 +1386,7 @@ openedx-filters==1.11.0
# -r requirements/edx/testing.txt
# lti-consumer-xblock
# ora2
openedx-learning==0.18.0
openedx-learning==0.18.1
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/doc.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/doc.txt
Original file line number Diff line number Diff line change
Expand Up @@ -997,7 +997,7 @@ openedx-filters==1.11.0
# -r requirements/edx/base.txt
# lti-consumer-xblock
# ora2
openedx-learning==0.18.0
openedx-learning==0.18.1
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
Expand Down
2 changes: 1 addition & 1 deletion requirements/edx/testing.txt
Original file line number Diff line number Diff line change
Expand Up @@ -1042,7 +1042,7 @@ openedx-filters==1.11.0
# -r requirements/edx/base.txt
# lti-consumer-xblock
# ora2
openedx-learning==0.18.0
openedx-learning==0.18.1
# via
# -c requirements/edx/../constraints.txt
# -r requirements/edx/base.txt
Expand Down

0 comments on commit 8ef3c11

Please sign in to comment.