Add patches that mitigate compiler bugs and missing includes for some compiler versions #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… compiler versions (see links in the path files for more detail) Signed-off-by: Goshik92 <[email protected]>
mimir-d
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
mainbranch cannot be compiled due to a bug in GCC (also known to exist in Clang). The bug is triggered in an older version of Google's GRPC library (not sure why OCP results library would even require it). This problem is mitigated in newer versions of grpc, but it is very difficult for us to upgrade the dependencies in ocp-diag-core-cpp at the moment. Thus, I just applied a few cherry-picked patches to our existing dependencies.Recently, our vendor confirmed that they managed to compile the library with the fix provided in this PR, so I am proposing it for merging.