Make minion reconnecting on changing master IP with zeromq #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vzhestkov
changed the title
vzhestkov
changed the title
Check for a chainging dns record anytime a minion gets disconnected from it's master. See github issue #63654 #61482.
Adding tests to validate we check for changing dns anytime we're disconnected from the currently connected master
Update docs to use master_alive_interval to detect master ip changes via DNS.
with zeromq transport
vzhestkov
force-pushed
the
openSUSE/improve/3006.0/reconnect-on-master-ip-change
branch
from
3454ad2
to
8c465dc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Backport of upstream PRs: saltstack/salt#66760, saltstack/salt#66757, saltstack/salt#66422
By default
salt-minionis not able to detect disconnects from the master as callback is not called on disconnet due to the missing possibility with no zeromq monitor socket.This PR adds the possibility to detect disconnects and react on it.
What issues does this PR fix or reference?
Tracks: https://github.com/SUSE/spacewalk/issues/24752, https://github.com/SUSE/spacewalk/issues/24871
Previous Behavior
The minion is unable to switch to the master with the same FQDN but different IP address as it's not resolving IP address after connecting to the master. ZeroMQ socket is handling reconnects internally, but as it has IP address specified to connect to, it's not trying to resolve it anymore.
New Behavior
The minion is able to reconnect to the master on it's IP address change.
Merge requirements satisfied?
[NOTICE] Bug fixes or features added to Salt require tests.
Commits signed with GPG?
Yes/No
Please review Salt's Contributing Guide for best practices.
See GitHub's page on GPG signing for more information about signing commits with GPG.