Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include passlib as a dependency #100

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

m-czernek
Copy link
Contributor

We added passlib to Salt bundle, but not here; WDYT?

Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure it's a build requirement? I suppose it should be the requirement for the package installation, so Requires: python3-passlib, and I'm not sure if it should be a strict requirement, maybe better to use Recommends. With Requires most probably we need to adjust the bootstrap repo definitions to include passlib to the bootstrap repo.

@m-czernek
Copy link
Contributor Author

Changed - I used buildrequires because that's what we use in Bundle, but you're right, it's not a build dep for non-bundle Salt. WDYT now? Also, please double check the location of the recommends - I placed it where I believe it'll apply to all systems (and that should be correct?)

Copy link
Contributor

@vzhestkov vzhestkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not fully sure about EL8 clones, some of them has no such package at all, maybe better to move up inside such section:

%if 0%{?suse_version}
...
%endif

but with Recommends it should be fine anyway

@vzhestkov
Copy link
Contributor

For the bundle it's in the BuildRequires as it should be available while building the package to include to the resulting, but with the classic salt packages we are not including anything during the build time, so this is the requirement for the package when it's installed on the system.

@m-czernek m-czernek merged commit 264aade into openSUSE:release/3006.0 Oct 17, 2024
2 checks passed
@m-czernek m-czernek deleted the salt-passlib branch October 17, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants