Remove unnecesary retrying on updates of packages' issues #16956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If saving an event results in an ActiveRecord::StatementInvalid exception, just retrying to save that event 10 times doesn't make a difference. Also, don't rescue from StandardError exceptions to handle them exactly as we do in the rest of the application.
If updating packages' issues results in an error, just retrying 10 times to update them doesn't make a difference. Also, prevent from masking generic Mysql2::Error exceptions. We would like to handle those exceptions like any other exception in the application. Correct handling of concurrent updates of packages and packages' issues is guaranteed using Active Jobs.
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #16954.
We want to deploy these pull requests separately.
This PR is the second of a group of pull requests: