Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename feature_flag.system back to feature_flag.provider_name #1614

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lmolkova
Copy link
Contributor

@lmolkova lmolkova commented Nov 26, 2024

Extracted from #1613

Given uncertainty around *.system attribute, I'd like to revert recent unreleased changes to feature_flag.system and rename it back to feature_flag.provider_name. This would reduce number of breaking changes.

We can't call it feature_flag.provider.name yet due to const name collision with existing ``feature_flag.provider_name` - #1462

Merge requirement checklist

@lmolkova lmolkova requested review from a team as code owners November 26, 2024 02:02
@dyladan
Copy link
Member

dyladan commented Nov 26, 2024

Should I assume this is a temporary reversion until a final decision is made regarding #1581 et alia?

@lmolkova
Copy link
Contributor Author

Should I assume this is a temporary reversion until a final decision is made regarding #1581 et alia?

yes, this is temporary until we have a final consistent pattern.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants