Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generalize db.query.parameter.<key> to db.operation.parameter.<key> #1559

Merged
merged 4 commits into from
Nov 13, 2024

Conversation

trask
Copy link
Member

@trask trask commented Nov 8, 2024

Generalize db.query.parameter.<key> to db.operation.parameter.<key>, so that it can be used also for stored procedure parameters as well (and maybe other kinds of operations?)

Note: I don't think(?) schema transforms support attribute type template[string]

@trask trask force-pushed the generalize-db-query-parameters branch 2 times, most recently from 6628583 to b9f7d83 Compare November 8, 2024 02:15
@trask trask force-pushed the generalize-db-query-parameters branch from b9f7d83 to b06f056 Compare November 8, 2024 02:26
@trask trask marked this pull request as ready for review November 8, 2024 02:28
@trask trask requested review from a team as code owners November 8, 2024 02:28
@lmolkova
Copy link
Contributor

lmolkova commented Nov 8, 2024

Note: I don't think(?) schema transforms support attribute type template[string]

@lquerel this is another data point on schema transformation limitations. Do we have an existing tracking issue I can update to include it?

@lquerel
Copy link
Contributor

lquerel commented Nov 8, 2024

@lmolkova, we have two GitHub issues related to this topic:

  1. Why we need to change the way the OTEL Schema is specified: Limitations and evolution of the OpenTelemetry Schema file.
  2. The diff format I’m proposing, which could serve as the basis for a migration guide, schema update, etc.: Diff between two versions of a semconv registry - Proposal.

It would be great to get your feedback on one or both of these issues, especially in light of the discussions in the current PR.

Note: I don't think(?) schema transforms support attribute type template[string]

@lquerel this is another data point on schema transformation limitations. Do we have an existing tracking issue I can update to include it?

Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to (eventually) support this in Schema URL. For now, marking this breaking in changelog seems the only thing we can really do.

IIRC - the plan is to have a "2.0" like migration period for DB instrumentation right?

@lmolkova lmolkova merged commit 62306fc into open-telemetry:main Nov 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants