Add OTLP integration test for hyper and request client for logs and traces #2312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Moving to draft to fix build issues |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2312 +/- ##
=====================================
Coverage 79.5% 79.5%
=====================================
Files 123 123
Lines 21492 21492
=====================================
+ Hits 17094 17096 +2
+ Misses 4398 4396 -2 ☔ View full report in Codecov by Sentry. |
ok fixed the build now. |
lalitb
changed the title
TommyCpp
approved these changes
Nov 29, 2024
TommyCpp
reviewed
Nov 29, 2024
Comment on lines
+18
to
+23
| #[cfg(not(feature = "tonic-client"))] | ||
| #[cfg(any( | ||
| feature = "hyper-client", | ||
| feature = "reqwest-client", | ||
| feature = "reqwest-blocking-client" | ||
| ))] |
There was a problem hiding this comment.
Would be nice to combine those two though. Maybe we can use cfg_if it's dev only so it's easier to introduce the dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
reqwest-blocking is failing, could be the issue with the exporter. will fix that separately.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes