Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ruff rule B and N #4234

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Neema-Joju
Copy link

Description

Address part of #4227

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • ruff check . --select N (Adding rule N checks the code against PEP 8 naming conventions.)

Does This PR Require a Contrib Repo Change?

  • Yes. - Link to PR:
  • No.

Checklist:

  • Followed the style guidelines of this project
  • Changelogs have been updated
  • Unit tests have been added
  • Documentation has been updated

@Neema-Joju Neema-Joju requested a review from a team as a code owner October 22, 2024 16:01
@Neema-Joju Neema-Joju changed the title Adding ruff rule N Adding ruff rule B and N Oct 23, 2024
@Neema-Joju Neema-Joju marked this pull request as draft October 23, 2024 01:55
@Neema-Joju Neema-Joju marked this pull request as ready for review October 23, 2024 01:56
@xrmx xrmx added the Skip Changelog PRs that do not require a CHANGELOG.md entry label Nov 21, 2024
@xrmx
Copy link
Contributor

xrmx commented Nov 21, 2024

AFAICS Not a fan of N warnings, most of the A and B are not that useful either

@Kludex
Copy link

Kludex commented Nov 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog PRs that do not require a CHANGELOG.md entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants