Cache successful requests in lychee #6030
Merged
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmathieu
requested review from
MrAlias,
XSAM,
dashpole and
pellared
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6030 +/- ##
=====================================
Coverage 82.2% 82.2%
=====================================
Files 273 273
Lines 23647 23647
=====================================
Hits 19449 19449
Misses 3851 3851
Partials 347 347 |
pellared
approved these changes
Dec 10, 2024
MrAlias
approved these changes
Dec 10, 2024
XSAM
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does the same as we do in contrib, which is to cache successful requests in lychee, so errors such as 429s have less changes of occuring.
https://github.com/open-telemetry/opentelemetry-go-contrib/blob/main/.github/workflows/links.yml#L33