sdk/log: Add design doc #4954
Merged
sdk/log: Add design doc #4954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pellared
added
pkg:SDK
Closed
pellared
requested review from
MrAlias,
Aneurysm9,
evantorrie,
XSAM,
dashpole,
MadVikingGod,
hanyuancheung and
dmathieu
as code owners
|
Ready for initial high-level review, before I start implementing the prototype. |
This comment was marked as outdated.
This comment was marked as outdated.
pellared
commented
Mar 6, 2024
MrAlias
reviewed
Mar 6, 2024
Co-authored-by: Tyler Yahn <[email protected]>
|
@open-telemetry/go-approvers Ready for review |
MrAlias
reviewed
Mar 11, 2024
Co-authored-by: Tyler Yahn <[email protected]>
MrAlias
approved these changes
Mar 11, 2024
Co-authored-by: Sam Xie <[email protected]> Co-authored-by: David Ashpole <[email protected]>
|
My plan is to merge this PR on Friday morning given there is no significant feedback. |
dmathieu
approved these changes
Mar 12, 2024
MadVikingGod
approved these changes
Mar 12, 2024
|
Given the amount of approvals this PR received, I plan to merge it tomorrow morning. |
|
Thank you @pellared |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4896
Prototype: #4955 (use it for reference when reviewing)