Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove never used param skip_list and fix doc string #3131

Open
wants to merge 5 commits into
base: dev-1.x
Choose a base branch
from

Conversation

LeoJhonSong
Copy link

@LeoJhonSong LeoJhonSong commented Oct 5, 2024

Motivation

It seems code of SimpleMPJPE() in mmpose/evaluation/metrics/simple_keypoint_3d_metrics.py was modified based on MPJPE() in mmpose/evaluation/metrics/keypoint_3d_metrics.py, however the parameter skip_list was never used in SimpleMPJPE() and should be removed to eliminate confusion. Besides, doc string about mode of SimpleMPJPE() and MPJPE() has mistake.

Modification

  • unused code and doc string related to skip_list are removed
  • fix doc string of MPJPE() and SimpleMPJPE()

Checklist

Before PR:

  • I have read and followed the workflow indicated in the CONTRIBUTING.md to create this PR.
  • Pre-commit or linting tools indicated in CONTRIBUTING.md are used to fix the potential lint issues.
  • Bug fixes are covered by unit tests, the case that causes the bug should be added in the unit tests.
  • New functionalities are covered by complete unit tests. If not, please add more unit tests to ensure correctness.
  • The documentation has been modified accordingly, including docstring or example tutorials.

After PR:

  • CLA has been signed and all committers have signed the CLA in this PR.

@CLAassistant
Copy link

CLAassistant commented Oct 5, 2024

CLA assistant check
All committers have signed the CLA.

@LeoJhonSong LeoJhonSong changed the title remove never used param skip_list remove never used param skip_list and fix doc string Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants