Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OptiGUI Extra - OptiGUI integration with other mods #71

Draft
wants to merge 15 commits into
base: dev
Choose a base branch
from
Draft

Conversation

opekope2
Copy link
Owner

@opekope2 opekope2 commented Aug 30, 2023

Here are the mods I found in the issues (and some related):

QuickShulker

#19 has been a long ongoing issue. I originally submitted a QuickShulker patch.
Now I took my time to add support on the OptiGUI side. This means that the next version of OptiGUI will support the current (and possible past) versions of QuickShulker, without any new or updated server-side mod.

More Chest Variants

Added a processor for the MCV block entity.

Variant Barrels

Only needed to specify the default textures of the added blocks.

Variant Crafting Tables

Same as Variant Barrels.

Variant Vanilla Blocks

Added support for all variant blocks with GUI.

Variant Grindstones

No 1.20 versions are available. The 1.19.2 version is incompatible with a newer Fabric API.

Linked Storage

I don't see it being difficult, but I haven't yet worked on it.

Question to discuss (feel free to express your opinion)

As of now, OptiGUI, and OptiGUI Extra are in the same repository, but different projects.
There are two options I can distribute OptiGUI extra:

  1. As a nested JAR inside OptiGUI
  • Will always be loaded
  • "Just works" - built-in compatibility with other mods without manually downloading OptiGUI extra
  • May be unwanted by Vanilla+QoL players (like only Fabulously Optimized)
  • Relatively small JAR, less about 3-4% of OptiGUI (how did OptiGUI get so big?)
  1. As a separate mod (different Modrinth+CurseForge page)
  • The player can choose to download
  • The player may not know about it
  • Independent from OptiGUI - support for a mod can be "backported" to older OptiGUI versions, and updating OptiGUI is not required

I'll document the new features when I release alpha 1, so other mod devs can choose to add compatibility to their mod. I'll also create an issue template for requesting mod compatibility (which usually doesn't take long to implement)

@opekope2 opekope2 marked this pull request as draft August 30, 2023 20:04
@opekope2 opekope2 marked this pull request as draft August 30, 2023 20:04
@dadoirie
Copy link

dadoirie commented Sep 1, 2023

If you haven't yet decided how to distribute OptiGUI extra I'd say option 2, as a separate mod/add-on, would be the plausible, because as you pointed out the QoL players/modpacks & also vanilla resource packs and the extra version is more for (heavily) modded players/modpacks & resource packs which support for mods. Also with a note in the OptiGUI description as well resource packs pages can point out that OptiGUI Extra is needed for additional support of mods.

@Madis0
Copy link

Madis0 commented Sep 1, 2023

I would actually ask you something different - why make Extra to add compatibility instead of the mods that want to have compatibility add Extra by themselves?

Is it because you're more interested in supporting them than they are supporting you? If that is the case, who is even the target audience for this?

That said, I vote Extra to be independent, and the discovery could be solved by marking dependencies - Extra suggests mods that are compatible with it and/or mods that are compatible suggest Extra. Could be done in CurseForge/Modrinth metadata, listing description, fabric.mod.json etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants