API Proposal: Previewers #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalAmuyal
reviewed
Mar 21, 2018
There was a problem hiding this comment.
What do you think of making it a plugin?
I think it's a good opportunity to make a plugin that can function as an infrastructure provider for other plugins.
Advantages in pluginzing that I see:
- Reducing code-base complexity
- Standardizing modules
- Making it easier to solve problems system-wide
- Compos-ability is really cool
|
Sorry for the slow reply, @TalAmuyal ! I think making it a plugin makes a lot of sense - especially with the direction we're going with onivim/oni#2020 and onivim/oni#2022 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an initial API proposal for the 'generalized preview' functionality - the ability to register arbitrary preview strategies.