Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[KT] Rename out-of-place esimd radix_sort as radix_sort_copy #1629

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

danhoeflinger
Copy link
Contributor

@danhoeflinger danhoeflinger commented Jun 20, 2024

It is the convention of the standard library when both an in-place and out-of-place algorithm are provided to to label out-of-place versions of APIs as *_copy. See partial_sort[_copy], remove[_copy], partition[_copy], etc..

This PR deprecates the existing out-of-place overloads for radix_sort and radix_sort_by_key in favor of radix_sort_copy and radix_sort_copy_by_key. We originally avoided this to limit the line length with the large KT namespace, but the convention is strong and consistent enough to warrant this change.

This updates the code, the testing, and the documentation.

This PR is based on #1586 to avoid merge conflicts, and should be merged into main after that PR is merged. For now I will point it at that PR and keep it as "draft", to properly show the diff.

Signed-off-by: Dan Hoeflinger <[email protected]>
Base automatically changed from dev/dmitriy-sobolev/doc-esimd-split to main July 4, 2024 09:47
@akukanov akukanov added the follow through PRs/issues that should be completed/resolved label Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
follow through PRs/issues that should be completed/resolved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants