[SYCLomatic]Enable migration CUBLASLT_MATRIX_LAYOUT_BATCH_COUNT #2421
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Oct 20, 2024
| // CHECK-NEXT: matLayout = new dpct::blas_gemm::experimental::matrix_layout_t(type, rows, cols, ld); | ||
| cublasLtMatrixLayout_t matLayout; | ||
| cudaDataType type; | ||
| uint64_t rows; | ||
| uint64_t cols; | ||
| int64_t ld; | ||
| cublasLtMatrixLayoutCreate(&matLayout, type, rows, cols, ld); | ||
| uint64_t batch_count; | ||
| cublasLtMatrixLayoutCreate(&matLayout, type, rows, cols, ld, batch_count); |
There was a problem hiding this comment.
Suggested change
| cublasLtMatrixLayoutCreate(&matLayout, type, rows, cols, ld, batch_count); | |
| cublasLtMatrixLayoutCreate(&matLayout, type, rows, cols, ld); |
cublasLtMatrixLayoutCreate does not accept batch_count as a parameter. https://docs.nvidia.com/cuda/cublas/#cublasltmatrixlayoutcreate
zhiweij1
reviewed
Oct 20, 2024
| @@ -1916,6 +1916,9 @@ void MapNames::setExplicitNamespaceMap( | |||
| {"CUBLASLT_MATRIX_LAYOUT_TYPE", | |||
| getLibraryHelperNamespace() + | |||
| "blas_gemm::experimental::matrix_layout_t::attribute::type"}, | |||
| {"CUBLASLT_MATRIX_LAYOUT_BATCH_COUT", | |||
There was a problem hiding this comment.
Suggested change
| {"CUBLASLT_MATRIX_LAYOUT_BATCH_COUT", | |
| {"CUBLASLT_MATRIX_LAYOUT_BATCH_COUNT", |
zhiweij1
reviewed
Oct 20, 2024
| @@ -62,11 +62,11 @@ class descriptor { | |||
|
|
|||
| class matrix_layout_t { | |||
| public: | |||
| enum class attribute { type, order, rows, cols, ld }; | |||
| enum class attribute { type, order, rows, cols, ld, batch_count}; | |||
There was a problem hiding this comment.
Suggested change
| enum class attribute { type, order, rows, cols, ld, batch_count}; | |
| enum class attribute { type, order, rows, cols, ld, batch_count }; |
zhiweij1
reviewed
Oct 21, 2024
Comment on lines
+68
to
+69
| std::int64_t ld, std::uint64_t batch_count=1) | ||
| : _type(type), _rows(rows), _cols(cols), _ld(ld), _batch_count(batch_count) {} |
There was a problem hiding this comment.
I prefer to keep the constructor since its parameters can 1:1 mapping to cublasLtMatrixLayoutCreate. We can use set/get_attribute() to access the value.
And please add a private std::uint64_t _batch_count; member in this class.
Suggested change
| std::int64_t ld, std::uint64_t batch_count=1) | |
| : _type(type), _rows(rows), _cols(cols), _ld(ld), _batch_count(batch_count) {} | |
| std::int64_t ld) | |
| : _type(type), _rows(rows), _cols(cols), _ld(ld)) {} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhiweij1 @zhimingwang36