[SYCLomatic]Enable migration for CUBLASLT_MATMUL_DESC_BIAS_DATA_TYPE #2385
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhiweij1
reviewed
Oct 7, 2024
| @@ -133,7 +134,7 @@ class matmul_desc_t { | |||
| }; | |||
|
|
|||
| matmul_desc_t(compute_type compute_type, library_data_t scale_type) | |||
| : _compute_type(compute_type), _scale_type(scale_type) {} | |||
| : _compute_type(compute_type), _scale_type(scale_type), _bias_type(bias_type) {} | |||
There was a problem hiding this comment.
There is no bias_type in the constructor parameter, so you can give a default value directly:
Suggested change
| : _compute_type(compute_type), _scale_type(scale_type), _bias_type(bias_type) {} | |
| : _compute_type(compute_type), _scale_type(scale_type), _bias_type(some default value) {} |
There was a problem hiding this comment.
Ok Wiill modify this
There was a problem hiding this comment.
I changed to library_data_t for bias_type (similar to scalar type).
@zhiweij1 could you please suggest ? Thanks
There was a problem hiding this comment.
71bac7a is right. But you have not correct the init list of the constructor. Another option is removing , _bias_type(bias_type) in the init list and set the default value at line 179.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@zhiweij1 @zhimingwang36