-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCLomatic] Change the pointer_t to element_t to add const qualifier if needed. #2384
Open
ShengchenJ
wants to merge
4
commits into
oneapi-src:SYCLomatic
Choose a base branch
from
ShengchenJ:quick_fix_0927
base: SYCLomatic
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Chen, Sheng S <[email protected]>
ShengchenJ
force-pushed
the
quick_fix_0927
branch
from
October 8, 2024 01:36
a4f2753
to
89ab6f4
Compare
zhiweij1
approved these changes
Oct 10, 2024
ShengchenJ
changed the title
[SYCLomatic] Fix the const issue in dpct header.
[SYCLomatic] Change the pointer_t to element_t to add const if needed.
Oct 11, 2024
ShengchenJ
changed the title
[SYCLomatic] Change the pointer_t to element_t to add const if needed.
[SYCLomatic] Change the pointer_t to element_t to add const qualifier if needed.
Oct 11, 2024
Signed-off-by: Chen, Sheng S <[email protected]>
ziranzha
approved these changes
Oct 11, 2024
ShengchenJ
force-pushed
the
quick_fix_0927
branch
from
October 11, 2024 08:10
2933e50
to
5f146bb
Compare
Signed-off-by: Chen, Sheng S <[email protected]>
Signed-off-by: Chen, Sheng S <[email protected]>
ShengchenJ
commented
Oct 18, 2024
@@ -1457,9 +1453,10 @@ template <class T, memory_region Memory> class accessor<T, Memory, 2> { | |||
accessor(typename std::enable_if<M != local, const accessor_t>::type &acc) | |||
: accessor(acc, acc.get_range()) {} | |||
accessor(const accessor_t &acc, const sycl::range<2> &in_range) | |||
: accessor( | |||
acc.template get_multi_ptr<sycl::access::decorated::no>().get(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add deprecated message.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.