[SYCLomatic][python_setup] Enabled Python build scripts migration #2171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
from
dc3bbe7
to
fbd8f17
Compare
TejaX-Alaghari
changed the title
tomflinda
requested changes
Jul 18, 2024
There was a problem hiding this comment.
clang/lib/DPCT/MigratePythonSetupScript.cpp
clang/lib/DPCT/MigratePythonSetupScript.h
Has duplicate function's implementation with
clang/lib/DPCT/MigrateCmakeScript.cpp
clang/lib/DPCT/MigrateCmakeScript.h
So, I suggest that:
Create two more files, like:
clang/lib/DPCT/MigrateBuildScript.cpp
clang/lib/DPCT/MigrateBuildScript.cpp
And extract common implementation from MigratePythonSetupScript.cpp and MigrateCmakeScript.cpp to the two files above, so than the duplicate code could be reduced.
TejaX-Alaghari
changed the title
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
from
faeffd9
to
6fee9fa
Compare
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
3 times, most recently
from
25472c1
to
c74b205
Compare
tomflinda
reviewed
Sep 26, 2024
tomflinda
reviewed
Sep 26, 2024
tomflinda
reviewed
Sep 26, 2024
tomflinda
reviewed
Sep 26, 2024
tomflinda
reviewed
Sep 26, 2024
tomflinda
reviewed
Sep 26, 2024
tomflinda
reviewed
Sep 26, 2024
clang/test/dpct/python_setup_migration/case_001/case_001_framework.cpp
Outdated
Show resolved
Hide resolved
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
3 times, most recently
from
988c66e
to
ccf302e
Compare
clang/tools/dpct/DpctOptRules/python_setup_script_migration_rule.yaml
Outdated
Show resolved
Hide resolved
clang/tools/dpct/DpctOptRules/python_setup_script_migration_rule.yaml
Outdated
Show resolved
Hide resolved
clang/tools/dpct/DpctOptRules/python_setup_script_migration_rule.yaml
Outdated
Show resolved
Hide resolved
clang/tools/dpct/DpctOptRules/python_setup_script_migration_rule.yaml
Outdated
Show resolved
Hide resolved
clang/tools/dpct/DpctOptRules/python_setup_script_migration_rule.yaml
Outdated
Show resolved
Hide resolved
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
2 times, most recently
from
e47e4ce
to
e9a3354
Compare
tomflinda
reviewed
Oct 11, 2024
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
2 times, most recently
from
ace0fa4
to
0ad9293
Compare
TejaX-Alaghari
changed the title
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
from
ca5583d
to
f4d9b19
Compare
TejaX-Alaghari
force-pushed
the
setup_py_mig
branch
from
cb5353d
to
b9eeb62
Compare
zhimingwang36
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial PR for enabling setup.py migration framework