Run shellcheck from the project root #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows project specific shellcheck settings to be applied.
|
@samdoran thanks for the pull request. Apologies for the delay in getting back to you. I've changed your modifications slightly to keep the existing behaviour (where it runs with the working directory in the Application Support folder) when there's no workspace path configured. I'll endeavour to get this built and released ASAP. |
|
I've released v1.2 which includes this update. Thanks again for your contribution. 🙏 |
Closed
|
Thank you so much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows project specific
shellchecksettings to be applied.It took me quite a while to figure out why this plugin wasn't using the settings in the
.shellcheckrcat the root of the repository. It's becauseshellcheckwalks up the directory path until it finds the first.shellcheckrc. The default directory where theshellcheckprocess is executed is~/Library/Application Support/Nova/Extensions/[extension directory].