Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc cleanup #956

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Misc cleanup #956

merged 3 commits into from
Oct 10, 2024

Conversation

oliver006
Copy link
Owner

No description provided.

@oliver006 oliver006 changed the title [wip] Misc cleanup Oct 5, 2024
Copy link

codecov bot commented Oct 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.94%. Comparing base (6d86815) to head (28a429e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #956   +/-   ##
=======================================
  Coverage   81.94%   81.94%           
=======================================
  Files          18       18           
  Lines        2204     2204           
=======================================
  Hits         1806     1806           
  Misses        311      311           
  Partials       87       87           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coveralls
Copy link

coveralls commented Oct 5, 2024

Pull Request Test Coverage Report for Build 11267921569

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 85.368%

Totals Coverage Status
Change from base Build 11238689041: 0.0%
Covered Lines: 2252
Relevant Lines: 2638

💛 - Coveralls

Copy link
Contributor

@mindw mindw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For what it's worth LGTM!

@oliver006
Copy link
Owner Author

For what it's worth LGTM!

Thanks :-)

@oliver006 oliver006 merged commit b879136 into master Oct 10, 2024
11 checks passed
@oliver006 oliver006 deleted the oh_ci branch October 10, 2024 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants