Adds logic to find the correct vcs path #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More of a PRFC than an actual PR. I'm not super familiar with omf and fish, so I'm flying by the seat of my pants. This broke for me today because
$conf_pathwas being passed in as an array, so$vcs_pathwas automatically being set to the first element of the array, which in my case was not the vcs path, but something else based on my plugin installations (and probably the order in which the directories are traversed by fish).Happy to make adjustments if you have a better strategy for selecting the correct directory, or maybe something is messed up in my installation and I just need to tear it down and reinstall 🤷.
Signed-off-by: Michael Stergianis [email protected]