prov/lnx: Convert peer table to use buffer pools #10597
Open
+131
−132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Convert peer table to use buffer pools in order to utilize the built-in capabilities of expanding the table as more peers are added dynamically. The peer table is protected by a read/write lock. Locking/unlocking callbacks are set only if needed. Signed-off-by: Amir Shehata <[email protected]>
amirshehataornl
force-pushed
the
lnx-dynamic-av
branch
from
3a5219c
to
72e951b
Compare
aingerson
reviewed
Dec 3, 2024
Comment on lines
+205
to
+207
| void (*lpt_rlock)(pthread_rwlock_t *l); | ||
| void (*lpt_wlock)(pthread_rwlock_t *l); | ||
| void (*lpt_unlock)(pthread_rwlock_t *l); |
There was a problem hiding this comment.
I think the fine tuning of the locks here is unnecessary and we can just use the lock in the util_av (which we can turn into a mutex to optimize out). If an application is interested in performant threading, then they should be using separate domains (and thus AVs) for their threads.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert peer table to use buffer pools in order to utilize the built-in capabilities of expanding the table as more peers are added dynamically.
The peer table is protected by a read/write lock. Locking/unlocking callbacks are set only if needed.