appveyor: update efa windows zip link #10584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old link was failing. Instead of downloading and extracting from zip file, just clone github repo to copy headers Signed-off-by: Alexia Ingerson <[email protected]>
.appveyor.ps1
Outdated
Comment on lines
18
to
20
| $efaWinVersion="v1.0.0" | ||
| Write-Verbose "downloading efawin ${efaWinVersion} files.." | ||
| git clone -b $efaWinVersion https://github.com/aws/efawin |
There was a problem hiding this comment.
The v1.0.0 branch ultimately needs to be deleted from aws/efawin, which would resolve this issue. I don't recommend merging this change if that happens.
|
We have deleted the stale v1.0.0 branch in that github and the tarball can be downloaded successfully now. @aingerson you can close this PR and retrigger your PR then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Old link was failing. Use new link