-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision/rename nominal value #1114
base: dev
Are you sure you want to change the base?
Conversation
I still have to keep explaining people what the nominal_value is meant for and they just understand if I name it nominal_capacity, instead. Reflecting a bit, the capacity of a Flow (e.g. a power line) is easier to interpret as the "nominal value". Thus the refactoring.
This way, it is analogue to teh keyword of the Flow.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@p-snft I had a look and introduced some fixes and suggestions.
I have some doubts concerning the renaming for the storage which is a consequence of the fact that the English term "capacity" similarly to the German term "Kapazität" can have different meanings.
For storages, we have a value in MWh, while for flows, we have a value in MW or whatever energy resp. power unit. Both are named "capacity", though, which might be slightly misleading, esp. for unexperienced users.
Maybe, one idea would be to rename to something like nominal_energy
for storages to make the physical dimensions clearer.
But anyways, feel free to decide on how to proceed with the renaming.
tests/test_scripts/test_solph/test_storage_investment/test_storage_investment.py
Outdated
Show resolved
Hide resolved
tests/test_scripts/test_solph/test_variable_chp/test_variable_chp.py
Outdated
Show resolved
Hide resolved
tests/test_scripts/test_solph/test_variable_chp/test_variable_chp.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Johannes Kochems <[email protected]>
Co-authored-by: Johannes Kochems <[email protected]>
Co-authored-by: Johannes Kochems <[email protected]>
…f-solph into revision/rename-nominal_value
Storages only have energy, Flows only have power. Thus, I think harmonisation is more beneficial than having different names. For both, the name is "nominal_capacity", both accept a value or an |
I think, the capacity of a
Flow
(e.g. a power line) is actually easier to interpret as the "nominal value". Actually, I have been asked that quite some times. If we have anominal_capacity
of aFlow
, it would be arguable why it'snominal_storage_capacity
for theGenericStorage
. So we need to say eithernominal_flow_capacity
which is actually redundant. In my opinion, it makes sense to call bothnominal_capacity
.In fact, they are quite similar. In particular, they both accept a number (fixed capacity) or an Investment object.