Attempt to fix the deprecation issues... #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- dni in the pvlib test has been calculated so that the old test target is reached. - I am not quite sure if the chosen dni is not too high.
Point.to_wkt() has been removed from shapely, and therefore must be replaced with Point.wkt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... described by @uvchik in #62.
Since the new version of pvlib has made some changes to the data structures of the PV models, I have adapted the respective accesses to the new structure.
In addition, the two new parameters "module_type" and "racking_model" were added.
These have to be set to the old state again on (Problems while running the feedin function #72)
The new version of pvlib also requires the direct normal irradiation (dni), which was calculated in the test file to reach the assert values again. For this purpose a zenith angle of about 75° was calculated. This seems a bit high for the first of January. Does anyone here have more detailed knowledge and can tell me what I need to change?
furthermore I removed the shapely deprecation in open_FRED.py.
Files touched: models/pvlib.py, open_FRED.py
Before I started my PR, the feedinlib already failed some tests on the Windpower model. This is still the case as I have not looked at the Windpowerlib.
After this PR the pvlib Version has to be >= 0.9.0 (dependencies)