-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: [1148] - enrichment extension #1149
Merged
pagbabian-splunk
merged 10 commits into
ocsf:main
from
PavelJurka:1148-enrichment-extension
Jul 30, 2024
Merged
Feat: [1148] - enrichment extension #1149
pagbabian-splunk
merged 10 commits into
ocsf:main
from
PavelJurka:1148-enrichment-extension
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelJurka
requested review from
floydtree,
pagbabian-splunk,
Aniak5,
mikeradka and
zschmerber
as code owners
July 22, 2024 12:13
Signed-off-by: Pavel Jurka <[email protected]>
floydtree
requested changes
Jul 22, 2024
Note - ticket added to incident finding change log record pushed back. |
floydtree
requested changes
Jul 23, 2024
floydtree
previously approved these changes
Jul 24, 2024
mikeradka
reviewed
Jul 24, 2024
mikeradka
reviewed
Jul 24, 2024
mikeradka
requested changes
Jul 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a couple of inline comments to look at.
mikeradka
previously approved these changes
Jul 26, 2024
Signed-off-by: Rajas <[email protected]>
mikeradka
approved these changes
Jul 26, 2024
floydtree
approved these changes
Jul 29, 2024
pagbabian-splunk
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: 1148
#1148
Description of changes:
extending - enrichment by:
time, recommended - The timestamp when the enrichment data was generated.
desc optional - A long description of the enrichment data.
reputation optional - The reputation of the enrichment data
short_desc, recommended - A short description of the enrichment data.
url_string, recommended - The URL of the source of the enrichment data