Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: [1148] - enrichment extension #1149

Merged
merged 10 commits into from
Jul 30, 2024

Conversation

PavelJurka
Copy link
Contributor

@PavelJurka PavelJurka commented Jul 22, 2024

Related Issue: 1148

#1148

Description of changes:

extending - enrichment by:

time, recommended - The timestamp when the enrichment data was generated.
desc optional - A long description of the enrichment data.
reputation optional - The reputation of the enrichment data
short_desc, recommended - A short description of the enrichment data.
url_string, recommended - The URL of the source of the enrichment data

objects/enrichment.json Outdated Show resolved Hide resolved
objects/enrichment.json Outdated Show resolved Hide resolved
@PavelJurka PavelJurka requested a review from floydtree July 23, 2024 07:25
@PavelJurka
Copy link
Contributor Author

Note - ticket added to incident finding change log record pushed back.

CHANGELOG.md Outdated Show resolved Hide resolved
@floydtree floydtree added the v1.3.0 Changes marked for v1.3.0 of OCSF label Jul 23, 2024
floydtree
floydtree previously approved these changes Jul 24, 2024
dictionary.json Outdated Show resolved Hide resolved
Copy link
Contributor

@mikeradka mikeradka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a couple of inline comments to look at.

mikeradka
mikeradka previously approved these changes Jul 26, 2024
@pagbabian-splunk pagbabian-splunk merged commit 85a36b7 into ocsf:main Jul 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v1.3.0 Changes marked for v1.3.0 of OCSF
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants