Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type enclosing deduplication #1864

Merged
merged 4 commits into from
Nov 26, 2024

Commits on Nov 21, 2024

  1. Configuration menu
    Copy the full SHA
    c5fd63b View commit details
    Browse the repository at this point in the history
  2. Refactor and fix deduplication in type enclosing.

    Deduplication can only be done if the type have been printed. We perform that printing only at the junction between the reconstructed identifier enclosings and the ones from the tree nodes because we often want to keep both. All other duplicated ranges are removed.
    voodoos committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    d6ba564 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    42ff215 View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Type-enclosing: revert deduplication in most cases

    Since deduplciation has been introduced a while ago the results of type-enclosing (the number of enclosings) have been unstable. This cannot be solved easily on the server-side without printing more types which can lead to performance issues when large modules are involed. We now leave the responsability of deduplication to the clients.
    voodoos committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    8cf640a View commit details
    Browse the repository at this point in the history