Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preview ocamlformat 0.27.0 preview1 #1861

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Julow
Copy link
Contributor

@Julow Julow commented Oct 30, 2024

The aim of this preview is to gather feedback.

Changelog can be found here: https://github.com/ocaml-ppx/ocamlformat/blob/main/CHANGES.md

@voodoos
Copy link
Collaborator

voodoos commented Oct 31, 2024

It looks like previously unformatted files are formatted (generated parser files in preprocess and sherlodoc). Is the due to the way you run the preview ?

@Julow
Copy link
Contributor Author

Julow commented Oct 31, 2024

I do dune build @fmt --auto-promote using dune 3.15.0 and I see these files being reformatted. Am I missing something ?

@voodoos
Copy link
Collaborator

voodoos commented Nov 1, 2024

Ah I see. It's an issue with Dune (or our config) that rebuilds the parser unexpectedly. Since your installed version of Menhir is not the same as the one the committed files are, there is a diff (which is unrelated to ocamlformat). We can simply ignore it for the purpose of the preview.

@Julow Julow force-pushed the preview-ocamlformat-0.27.0-preview1 branch from d1b1dc7 to 4c618c8 Compare November 28, 2024 10:13
@Julow Julow force-pushed the preview-ocamlformat-0.27.0-preview1 branch from 4c618c8 to ec9653d Compare November 28, 2024 10:31
@Julow Julow force-pushed the preview-ocamlformat-0.27.0-preview1 branch from ec9653d to 5f9ea50 Compare November 28, 2024 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants