-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocamlformat the codebase (again) #1834
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
WDYT about merging #1828 before, in order to include the sherlodoc
sublibrary in the formatting process?
I don't see why the order matters, the sherlodoc sublibrary will be formatted either way :-) |
9f6019f
to
0942318
Compare
This looks great to me! I opened a PR against this branch that makes a minor change: voodoos#14 Essentially, it allows you to specify a list of files in |
This looks great :) |
Thank you Liam, I cherry-picked your change and added a few more files. |
253fce4
to
406c764
Compare
I deactivated ocaml-ci so that we can finally format the codebase without breaking the CI..
Options are open for discussion... but not for long :-) @xvw @PizieDust
cc @liam923